lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Aug 2014 12:22:44 +0300 From: Horia Geantă <horia.geanta@...escale.com> To: Cristian Stoica <cristian.stoica@...escale.com> CC: <herbert@...dor.apana.org.au>, <davem@...emloft.net>, <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] crypto: testmgr.c: white space fix-ups on test_aead On 7/28/2014 1:11 PM, Cristian Stoica wrote: > This patch inverts two if conditions and allows removal of one > tab-stop in their code-blocks. Only white-space clean-up follows. > > Signed-off-by: Cristian Stoica <cristian.stoica@...escale.com> > --- > crypto/testmgr.c | 498 +++++++++++++++++++++++++++---------------------------- > 1 file changed, 242 insertions(+), 256 deletions(-) This increases readability and reduces number of lines, not to mention cyclomatic complexity. While here, could you do this also for other places, like __test_hash? Thanks, Horia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists