lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Aug 2014 12:25:36 +0200 From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> To: Julia Lawall <Julia.Lawall@...6.fr> Cc: Wolfram Sang <wsa@...-dreams.de>, kernel-janitors@...r.kernel.org, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH 1/14] i2c: mpc: delete unneeded test before of_node_put Hello, On Fri, Aug 08, 2014 at 12:07:42PM +0200, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@...6.fr> > > Of_node_put supports NULL as its argument, so the initial test is not > necessary. > > Suggested by Uwe Kleine-König. Thanks for picking up my suggestion. > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression e; > @@ > > -if (e) > of_node_put(e); > // </smpl> > I added devicetree@...r.kernel.org to Cc. Maybe they want to comment the series? If it's acceptable the logical next step is to add the patch to the collection of semantic patches, right? Best regards Uwe > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> > > --- > drivers/i2c/busses/i2c-mpc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c > index 6a32aa0..0edf630 100644 > --- a/drivers/i2c/busses/i2c-mpc.c > +++ b/drivers/i2c/busses/i2c-mpc.c > @@ -341,8 +341,7 @@ static u32 mpc_i2c_get_sec_cfg_8xxx(void) > iounmap(reg); > } > } > - if (node) > - of_node_put(node); > + of_node_put(node); > > return val; > } > > -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists