linux-kernel - Re: [PATCH 1/14] i2c: mpc: delete unneeded test before of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Aug 2014 12:27:03 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
cc:	Wolfram Sang <wsa@...-dreams.de>, kernel-janitors@...r.kernel.org,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 1/14] i2c: mpc: delete unneeded test before of_node_put



On Fri, 8 Aug 2014, Uwe Kleine-König wrote:

> Hello,
>
> On Fri, Aug 08, 2014 at 12:07:42PM +0200, Julia Lawall wrote:
> > From: Julia Lawall <Julia.Lawall@...6.fr>
> >
> > Of_node_put supports NULL as its argument, so the initial test is not
> > necessary.
> >
> > Suggested by Uwe Kleine-König.
> Thanks for picking up my suggestion.
>
> > The semantic patch that fixes this problem is as follows:
> > (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @@
> > expression e;
> > @@
> >
> > -if (e)
> >    of_node_put(e);
> > // </smpl>
> >
>
> I added devicetree@...r.kernel.org to Cc. Maybe they want to comment the
> series? If it's acceptable the logical next step is to add the patch to
> the collection of semantic patches, right?

Yes, I will do that.

julia