lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 08 Aug 2014 11:50:09 +0000 From: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@...achi.com> To: Hannes Reinecke <hare@...e.de> Cc: linux-scsi@...r.kernel.org, "Martin K. Petersen" <martin.petersen@...cle.com>, yrl.pp-manager.tt@...achi.com, linux-kernel@...r.kernel.org, "James E.J. Bottomley" <JBottomley@...allels.com>, Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>, Doug Gilbert <dgilbert@...erlog.com>, Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>, Christoph Hellwig <hch@....de> Subject: [RFC PATCH 02/10] scsi/constants: Cleanup printk message in scsi_decode_sense_extras() If sense_flags and fixed_valid are zero, the kernel does not need to output a printk message. So, if those conditions are met, it just returns. Signed-off-by: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@...achi.com> Cc: Hannes Reinecke <hare@...e.de> Cc: Doug Gilbert <dgilbert@...erlog.com> Cc: Martin K. Petersen <martin.petersen@...cle.com> Cc: Christoph Hellwig <hch@....de> Cc: "James E.J. Bottomley" <JBottomley@...allels.com> Cc: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com> Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> --- drivers/scsi/constants.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c index a0e8159..9c38b8d 100644 --- a/drivers/scsi/constants.c +++ b/drivers/scsi/constants.c @@ -1438,6 +1438,9 @@ scsi_decode_sense_extras(struct scsi_device *sdev, const char *name, sense_flags |= ucp[3] & 0xe0; } + if (!sense_flags && !fixed_valid) + return; + res = 0; memset(buff, 0, sizeof(buff)); blen = sizeof(buff) - 1; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists