lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 08 Aug 2014 11:50:12 +0000
From:	Yoshihiro YUNOMAE <>
To:	Hannes Reinecke <>
	"Martin K. Petersen" <>,,,
	"James E.J. Bottomley" <>,
	Hidehiro Kawai <>,
	Doug Gilbert <>,
	Masami Hiramatsu <>,
	Christoph Hellwig <>
Subject: [RFC PATCH 03/10] scsi/constants: Cleanup printk message in

All bytes in CDB should be output after linebuf is filled because
"[%s] CDB: %s\n" message is output many times in loop.

Signed-off-by: Yoshihiro YUNOMAE <>
Cc: Hannes Reinecke <>
Cc: Doug Gilbert <>
Cc: Martin K. Petersen <>
Cc: Christoph Hellwig <>
Cc: "James E.J. Bottomley" <>
Cc: Hidehiro Kawai <>
Cc: Masami Hiramatsu <>
 drivers/scsi/constants.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c
index 9c38b8d..5956d4d 100644
--- a/drivers/scsi/constants.c
+++ b/drivers/scsi/constants.c
@@ -413,9 +413,8 @@ void __scsi_print_command(struct scsi_device *sdev, const char *prefix,
 		hex_dump_to_buffer(cdb + i, linelen, 16, 1,
 				   linebuf, sizeof(linebuf), false);
-		sdev_printk(KERN_INFO, sdev, "[%s] CDB: %s\n",
-			    prefix, linebuf);
+	sdev_printk(KERN_INFO, sdev, "[%s] CDB: %s\n", prefix, linebuf);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists