[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 8 Aug 2014 07:28:44 +0200
From: Dirk Behme <dirk.behme@...bosch.com>
To: <mathieu.poirier@...aro.org>
CC: <linus.walleij@...aro.org>, <will.deacon@....com>,
<linux@....linux.org.uk>, <robherring2@...il.com>,
<daniel.thompson@...aro.org>, <robbelibobban@...il.com>,
<Al.Grant@....com>, <patches@...aro.org>,
<marcin.jabrzyk@...il.com>, <linux-kernel@...r.kernel.org>,
<panchaxari.prasannamurthy@...aro.org>, <r.sengupta@...sung.com>,
<arve@...roid.com>, <Tony.Armitstead@....com>,
<john.stultz@...aro.org>, <linux-arm-kernel@...ts.infradead.org>,
<james.king@...aro.org>, <pratikp@...eaurora.org>,
<varshney@...com>, <jonas.svennebring@...gotech.com>
Subject: Re: [PATCH 07/10 v3] coresight-etm: add CoreSight ETM/PTM driver
On 07.08.2014 20:21, mathieu.poirier@...aro.org wrote:
> From: Pratik Patel <pratikp@...eaurora.org>
>
> This driver manages CoreSight ETM (Embedded Trace Macrocell) that
> supports processor tracing. Currently supported version are ARM
> ETMv3.x and PTM1.x.
>
> Signed-off-by: Pratik Patel <pratikp@...eaurora.org>
> Signed-off-by: Panchaxari Prasannamurthy <panchaxari.prasannamurthy@...aro.org>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> ---
...
> +static struct amba_id etm_ids[] = {
> + { /* ETM 3.3 */
> + .id = 0x0003b921,
> + .mask = 0x0003ffff,
> + },
> + { /* ETM 3.5 */
> + .id = 0x0003b956,
> + .mask = 0x0003ffff,
> + },
> + { /* PTM */
> + .id = 0x0003b95f,
> + .mask = 0x0003ffff,
> + },
> + { 0, 0},
Maybe you like to add PTM 1.0 [1] here, too?
Best regards
Dirk
[1]
diff --git a/drivers/coresight/coresight-etm.c
b/drivers/coresight/coresight-etm.c
index 6f5dbc7..a7a08e6 100644
--- a/drivers/coresight/coresight-etm.c
+++ b/drivers/coresight/coresight-etm.c
@@ -1284,6 +1284,8 @@ static bool etm_arch_supported(u8 arch)
break;
case ETM_ARCH_V3_5:
break;
+ case PFT_ARCH_V1_0:
+ break;
case PFT_ARCH_V1_1:
break;
default:
@@ -1418,6 +1420,7 @@ static int etm_probe(struct amba_device *adev,
const struct amba_id *id)
put_online_cpus();
if (etm_arch_supported(drvdata->arch) == false) {
+ dev_err(dev, "ETM arch 0x%02x not supported\n", drvdata->arch);
ret = -EINVAL;
goto err_arch_supported;
}
@@ -1472,11 +1475,15 @@ static struct amba_id etm_ids[] = {
.id = 0x0003b921,
.mask = 0x0003ffff,
},
+ { /* PTM 1.0 */
+ .id = 0x0003b950,
+ .mask = 0x0003ffff,
+ },
{ /* ETM 3.5 */
.id = 0x0003b956,
.mask = 0x0003ffff,
},
- { /* PTM */
+ { /* PTM 1.1 */
.id = 0x0003b95f,
.mask = 0x0003ffff,
},
diff --git a/include/linux/coresight.h b/include/linux/coresight.h
index a19420e..596ec94 100644
--- a/include/linux/coresight.h
+++ b/include/linux/coresight.h
@@ -32,6 +32,7 @@
#define ETM_ARCH_V3_3 (0x23)
#define ETM_ARCH_V3_5 (0x25)
+#define PFT_ARCH_V1_0 (0x30)
#define PFT_ARCH_V1_1 (0x31)
#define CORESIGHT_UNLOCK (0xC5ACCE55)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists