linux-kernel - Re: [PATCH] btrfs: Drop stray check of fixup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 09 Aug 2014 08:26:01 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Andrey Utkin <andrey.krieger.utkin@...il.com>, clm@...com,
	jbacik@...com
CC:	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] btrfs: Drop stray check of fixup_workers creation

On 8/9/14, 6:51 AM, Andrey Utkin wrote:
> The issue was introduced in a79b7d4b3e8118f265dcb4bdf9a572c392f02708,
> adding allocation of extent_workers, so this stray check is surely not
> meant to be a check of something else.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=82021
> Reported-by: Maks Naumov <maksqwe1@....net>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@...il.com>

Yup, harmless but unneeded.

However, might as well put the extent_workers & qgroup_rescan_workers checks
on the same line now...

Could probably do a V2 or fix it on commit, but anyway:

Reviewed-by: Eric Sandeen <sandeen@...hat.com>

> ---
>  fs/btrfs/disk-io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 08e65e9..1881713 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -2601,7 +2601,7 @@ int open_ctree(struct super_block *sb,
>  	      fs_info->endio_freespace_worker && fs_info->rmw_workers &&
>  	      fs_info->caching_workers && fs_info->readahead_workers &&
>  	      fs_info->fixup_workers && fs_info->delayed_workers &&
> -	      fs_info->fixup_workers && fs_info->extent_workers &&
> +	      fs_info->extent_workers &&
>  	      fs_info->qgroup_rescan_workers)) {
>  		err = -ENOMEM;
>  		goto fail_sb_buffer;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/