linux-kernel - Re: [PATCH] staging: soc_camera: soc_camera_platform.c: Fixed a Missing blank line coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53E65EA4.6080106@xs4all.nl>
Date:	Sat, 09 Aug 2014 19:47:16 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Suman Kumar <suman@...orcecomputing.com>
CC:	m.chehab@...sung.com, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] staging: soc_camera: soc_camera_platform.c: Fixed a Missing
 blank line coding style issue

On 08/09/2014 07:36 PM, Guennadi Liakhovetski wrote:
> Hi Suman,
> 
> On Sat, 9 Aug 2014, Suman Kumar wrote:
> 
>>     Fixes a coding style issue reported by checkpatch.pl
> 
> Thanks for your patch. To my taste checkpatch.pl has unfortunately become 
> too noisy with meaningless / unimportant warnings like this one. Is this 
> in CodingStyle? If not, my intention is to drop this.

I don't see it being mentioned explicitly in the CodingStyle, but the coding
style follows K&R, and they put an empty line between local variables and the
start of the code. And I like it that way as well, it makes it easier to review.

If you don't want to be bothered by such patches, just delegate them to me in
patchwork, I don't mind.

Regards,

	Hans

> However, Mauro may 
> override by either taking this himself or asking me to apply this.
> 
> Thanks
> Guennadi
> 
>>
>> Signed-off-by: Suman Kumar <suman@...orcecomputing.com>
>> ---
>>  drivers/media/platform/soc_camera/soc_camera_platform.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/media/platform/soc_camera/soc_camera_platform.c b/drivers/media/platform/soc_camera/soc_camera_platform.c
>> index ceaddfb..fe15a80 100644
>> --- a/drivers/media/platform/soc_camera/soc_camera_platform.c
>> +++ b/drivers/media/platform/soc_camera/soc_camera_platform.c
>> @@ -27,12 +27,14 @@ struct soc_camera_platform_priv {
>>  static struct soc_camera_platform_priv *get_priv(struct platform_device *pdev)
>>  {
>>  	struct v4l2_subdev *subdev = platform_get_drvdata(pdev);
>> +
>>  	return container_of(subdev, struct soc_camera_platform_priv, subdev);
>>  }
>>  
>>  static int soc_camera_platform_s_stream(struct v4l2_subdev *sd, int enable)
>>  {
>>  	struct soc_camera_platform_info *p = v4l2_get_subdevdata(sd);
>> +
>>  	return p->set_capture(p, enable);
>>  }
>>  
>> -- 
>> 1.8.2
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/