linux-kernel - Re: [PATCH 05/33] perf record: Allow the user to disable time stamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140812145819.GA7737@gmail.com>
Date:	Tue, 12 Aug 2014 16:58:19 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	Andi Kleen <andi@...stfloor.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Stephane Eranian <eranian@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH 05/33] perf record: Allow the user to disable time stamps


* Arnaldo Carvalho de Melo <acme@...nel.org> wrote:

> Em Tue, Aug 05, 2014 at 08:08:56AM +0200, Ingo Molnar escreveu:
> > * Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> > > From: Andi Kleen <ak@...ux.intel.com>
>  
> > This patch looks dangerous and misleading to me.
> 
> I took it more from the angle: hey, it fixes a regression, i.e. 
> -T/--time somehow became a noop, and also it doesn't change any 
> default.
> 
> It also states that you will get misaccounting, why that would 
> happen, althought wording could've been better, as mmaps won't be 
> "missing", i.e. they will be there as this governs just 
> PERF_SAMPLE_TIME, not perf_event_attr.mmap, so it MMAPs may come 
> after samples for its maps.
> 
> So, I took it.
> 
> How should we proceed?

I'd be fine with applying the patch and fixing the misleading 
changelog.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/