linux-kernel - Re: [PATCH] staging: lustre: lustre: libcfs: workitem.c: Cleaning up missing null-terminate after strncpy call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJxHsr2YKL8vN2W24F_KEcVOAa480+VhCLB+re+hswtfg@mail.gmail.com>
Date:	Tue, 12 Aug 2014 07:58:50 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Peng Tao <bergwolf@...il.com>,
	Masanari Iida <standby24x7@...il.com>,
	Mike Sampson <mike@...bodata.com>, devel@...verdev.osuosl.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: lustre: lustre: libcfs: workitem.c: Cleaning up
 missing null-terminate after strncpy call

On Sat, Aug 9, 2014 at 4:46 PM, Rickard Strandqvist
<rickard_strandqvist@...ctrumdigital.se> wrote:
> Added a guaranteed null-terminate after call to strncpy.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  drivers/staging/lustre/lustre/libcfs/workitem.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/lustre/lustre/libcfs/workitem.c b/drivers/staging/lustre/lustre/libcfs/workitem.c
> index 0a03bf7..60326f2 100644
> --- a/drivers/staging/lustre/lustre/libcfs/workitem.c
> +++ b/drivers/staging/lustre/lustre/libcfs/workitem.c
> @@ -365,6 +365,7 @@ cfs_wi_sched_create(char *name, struct cfs_cpt_table *cptab,
>                 return -ENOMEM;
>
>         strncpy(sched->ws_name, name, CFS_WS_NAME_LEN);
> +       sched->ws_name[CFS_WS_NAME_LEN - 1] = '\0';
>         sched->ws_cptab = cptab;
>         sched->ws_cpt = cpt;

This seems like a place for strlcpy instead?

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/