linux-kernel - Re: [PATCH] Input: atmel_mxt_ts - fix a few issues reported by Coverity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53EA431F.6020908@itdev.co.uk>
Date:	Tue, 12 Aug 2014 17:38:55 +0100
From:	Nick Dyer <nick.dyer@...ev.co.uk>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org
CC:	Yufeng Shen <miletus@...omium.org>,
	Benson Leung <bleung@...omium.org>,
	Stephen Warren <swarren@...dia.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: atmel_mxt_ts - fix a few issues reported by Coverity

On 11/08/14 19:03, Dmitry Torokhov wrote:
> This should fix the following issues reported by Coverity:
> 
> *** CID 1230625:  Logically dead code  (DEADCODE)
> /drivers/input/touchscreen/atmel_mxt_ts.c: 1692 in mxt_initialize()
> 
> *** CID 1230627:  Missing break in switch  (MISSING_BREAK)
> /drivers/input/touchscreen/atmel_mxt_ts.c: 1436 in mxt_get_object_table()
> 
> *** CID 1230629:  Out-of-bounds write  (OVERRUN)
> /drivers/input/touchscreen/atmel_mxt_ts.c: 1267 in mxt_update_cfg()
> 
> *** CID 1230632:  Unused pointer value  (UNUSED_VALUE)
> /drivers/input/touchscreen/atmel_mxt_ts.c: 1211 in mxt_update_cfg()
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

I've reviewed these changes and they look correct to me. Apologies that
they slipped through, most of it is bad merging on my part I think.

Signed-off-by: Nick Dyer <nick.dyer@...ev.co.uk>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/