[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20140812150304.74a7da3f2491f3d8f8a30107@linux-foundation.org>
Date: Tue, 12 Aug 2014 15:03:04 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Tang Chen <tangchen@...fujitsu.com>
Cc: <santosh.shilimkar@...com>, <grygorii.strashko@...com>,
<phacht@...ux.vnet.ibm.com>, <yinghai@...nel.org>,
<fabf@...net.be>, <Emilian.Medve@...escale.com>,
<linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in
memblock_find_in_range_node().
On Sun, 10 Aug 2014 14:12:03 +0800 Tang Chen <tangchen@...fujitsu.com> wrote:
> In memblock_find_in_range_node(), we defeind ret as int. But it shoule
> be phys_addr_t because it is used to store the return value from
> __memblock_find_range_bottom_up().
>
> The bug has not been triggered because when allocating low memory near
> the kernel end, the "int ret" won't turn out to be minus. When we started
> to allocate memory on other nodes, and the "int ret" could be minus.
> Then the kernel will panic.
>
> A simple way to reproduce this: comment out the following code in numa_init(),
>
> memblock_set_bottom_up(false);
>
> and the kernel won't boot.
Which kernel versions need this fix?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists