[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <53EAF01C.3090404@cn.fujitsu.com>
Date: Wed, 13 Aug 2014 12:57:00 +0800
From: tangchen <tangchen@...fujitsu.com>
To: Andrew Morton <akpm@...ux-foundation.org>
CC: <santosh.shilimkar@...com>, <grygorii.strashko@...com>,
<phacht@...ux.vnet.ibm.com>, <yinghai@...nel.org>,
<fabf@...net.be>, <Emilian.Medve@...escale.com>,
<linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().
On 08/13/2014 06:03 AM, Andrew Morton wrote:
> On Sun, 10 Aug 2014 14:12:03 +0800 Tang Chen <tangchen@...fujitsu.com> wrote:
>
>> In memblock_find_in_range_node(), we defeind ret as int. But it shoule
>> be phys_addr_t because it is used to store the return value from
>> __memblock_find_range_bottom_up().
>>
>> The bug has not been triggered because when allocating low memory near
>> the kernel end, the "int ret" won't turn out to be minus. When we started
>> to allocate memory on other nodes, and the "int ret" could be minus.
>> Then the kernel will panic.
>>
>> A simple way to reproduce this: comment out the following code in numa_init(),
>>
>> memblock_set_bottom_up(false);
>>
>> and the kernel won't boot.
> Which kernel versions need this fix?
This bug has been in the kernel since v3.13-rc1.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists