linux-kernel - Re: [PATCH] perf ui/tui: Fix a small callchain display bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140813201210.GH2718@kernel.org>
Date:	Wed, 13 Aug 2014 17:12:10 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>, Andi Kleen <andi@...stfloor.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] perf ui/tui: Fix a small callchain display bug

Em Wed, Aug 13, 2014 at 10:19:09AM +0200, Ingo Molnar escreveu:
> * Namhyung Kim <namhyung@...nel.org> wrote:
> > Before:

> >   Children      Self  Command  Shared Object      Symbols
> > ---------------------------------------------------------------------------
> > -   40.70%     0.00%  swapper  [kernel.kallsyms]  [k] cpuidle_wrap_enter
> >    + cpuidle_wrap_enter
> >    + cpuidle_enter_tk
> >    + cpuidle_idle_call
> >    + cpu_idle

> > After:

> >   Children      Self  Command  Shared Object      Symbols
> > ---------------------------------------------------------------------------
> > -   40.70%     0.00%  swapper  [kernel.kallsyms]  [k] cpuidle_wrap_enter
> >      cpuidle_wrap_enter
> >      cpuidle_enter_tk
> >      cpuidle_idle_call
> >    + cpu_idle
> > 
> > Cc: Frederic Weisbecker <fweisbec@...il.com>
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> 
> Nice fix!

Indeed, longstanding problem, kudos to Namhyung for deving into TUI +
callchain land to fix this!

- Arnaldo
 
> Acked-by: Ingo Molnar <mingo@...nel.org>
> 
> Thanks,
> 
> 	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/