lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140814085409.GX15082@console-pimps.org> Date: Thu, 14 Aug 2014 09:54:09 +0100 From: Matt Fleming <matt@...sole-pimps.org> To: Guenter Roeck <linux@...ck-us.net> Cc: linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org, Matt Fleming <matt.fleming@...el.com> Subject: Re: [PATCH v2] firmware: Do not use WARN_ON(!spin_is_locked()) On Wed, 13 Aug, at 11:21:34AM, Guenter Roeck wrote: > spin_is_locked() always returns false for uniprocessor configurations > in several architectures, so do not use WARN_ON with it. > Use lockdep_assert_held() instead to also reduce overhead in > non-debug kernels. > > Cc: Matt Fleming <matt.fleming@...el.com> > Signed-off-by: Guenter Roeck <linux@...ck-us.net> > --- > v2: Use lockdep_assert_held instead of WARN_ON_SMP. > > drivers/firmware/efi/vars.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Thanks Guenter, applied! -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists