linux-kernel - Re: [PATCH] virtio: rng: add derating factor for use by hwrng core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140814185128.GA1894@z.redhat.com>
Date:	Fri, 15 Aug 2014 02:51:28 +0800
From:	Amos Kong <akong@...hat.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, hpa@...ux.intel.com,
	ricardo.neri-calderon@...ux.intel.com, tytso@....edu,
	Amit Shah <amit.shah@...hat.com>
Subject: Re: [PATCH] virtio: rng: add derating factor for use by hwrng core

On Thu, Aug 14, 2014 at 04:39:07AM +0930, Rusty Russell wrote:
> The khwrngd thread is started when a hwrng device of sufficient
> quality is registered.  The virtio-rng device is backed by the
> hypervisor, and we trust the hypervisor to provide real entropy.
> 
> A malicious hypervisor is a scenario that's irrelevant -- such a setup
> is bound to cause all sorts of badness, and a compromised hwrng is not
> the biggest threat.
> 
> Given this, we are certain the quality of randomness we receive is
> perfectly trustworthy.  Hence, we use 100% for the factor, indicating
> maximum confidence in the source.
> 
> Signed-off-by: Amit Shah <amit.shah@...hat.com>
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>


Reviewed-by: Amos Kong <akong@...hat.com>

> ---
> Pretty small and contained patch; would be great if it is picked up for
> 3.17.
> 
> v2: re-word commit msg
> 
> [Agreed, re-sending to Linus with SOB before jumping on plane]
> ---
>  drivers/char/hw_random/virtio-rng.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/hw_random/virtio-rng.c
> b/drivers/char/hw_random/virtio-rng.c
> index 0027137..2e3139e 100644
> --- a/drivers/char/hw_random/virtio-rng.c
> +++ b/drivers/char/hw_random/virtio-rng.c
> @@ -116,6 +116,7 @@ static int probe_common(struct virtio_device *vdev)
> 		.cleanup = virtio_cleanup,
> 		.priv = (unsigned long)vi,
> 		.name = vi->name,
> +		.quality = 1000,
> 	};
> 	vdev->priv = vi;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
			Amos.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/