linux-kernel - Re: [PATCH] drivers: staging: vt6655: wpactl.c checkpatch clean-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140815062740.GA19324@kroah.com>
Date:	Fri, 15 Aug 2014 14:27:40 +0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Avinash kumar <avi.kp.137@...il.com>
Cc:	forest@...ttletooquiet.net, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: vt6655: wpactl.c  checkpatch clean-up

On Mon, Aug 11, 2014 at 11:32:58AM +0530, Avinash kumar wrote:
> Cleaned all C99 comments related warnings
> 
> Signed-off-by: Avinash kumar <avi.kp.137@...il.com>
> 
> ---
>  drivers/staging/vt6655/wpactl.c |   40 +++++++++++++++++++--------------------
>  1 file changed, 20 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/wpactl.c b/drivers/staging/vt6655/wpactl.c
> index 8392d4d..96d2562 100644
> --- a/drivers/staging/vt6655/wpactl.c
> +++ b/drivers/staging/vt6655/wpactl.c
> @@ -299,7 +299,7 @@ int wpa_set_keys(PSDevice pDevice, void *ctx,
>  	else
>  		byKeyDecMode = KEY_CTL_WEP;
>  
> -	// Fix HCT test that set 256 bits KEY and Ndis802_11Encryption3Enabled
> +	/* Fix HCT test that set 256 bits KEY and Ndis802_11Encryption3Enabled*/

Why not a ' ' at the end of this line, before the '*/' part?  Yes, it
pushes you over the 80 character limit, but that's ok, it's something to
fix up later.


>  	if (pDevice->eEncryptionStatus == Ndis802_11Encryption3Enabled) {
>  		if (param->u.wpa_key.key_len == MAX_KEY_LEN)
>  			byKeyDecMode = KEY_CTL_TKIP;
> @@ -314,23 +314,23 @@ int wpa_set_keys(PSDevice pDevice, void *ctx,
>  			byKeyDecMode = KEY_CTL_WEP;
>  	}
>  
> -	// Check TKIP key length
> +	/* Check TKIP key length*/

Ok, no excuse this time :)

Please fix this all up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/