linux-kernel - Re: [PATCH v2] cpuidle/cpuidle-big_little: fix reading cpu id part number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53EE36F5.7000801@arm.com>
Date:	Fri, 15 Aug 2014 17:36:05 +0100
From:	Juri Lelli <juri.lelli@....com>
To:	Kevin Hilman <khilman@...aro.org>
CC:	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Will Deacon <Will.Deacon@....com>,
	Chao Xie <chao.xie@...vell.com>,
	Stephen Warren <swarren@...dia.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	Jonathan Austin <Jonathan.Austin@....com>,
	Chao Xie Linux <xiechao.mail@...il.com>,
	Juri Lelli <juri.lelli@...il.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] cpuidle/cpuidle-big_little: fix reading cpu id part
 number

On 15/08/14 17:32, Kevin Hilman wrote:
> Juri Lelli <juri.lelli@....com> writes:
> 
>> Commit af040ffc9ba1 ("ARM: make it easier to check the CPU part number
>> correctly") changed ARM_CPU_PART_X masks, and the way they are returned and
>> checked against. Usage of read_cpuid_part_number() is now deprecated, and
>> calling places updated accordingly. This actually broke cpuidle-big_little
>> initialization, as bl_idle_driver_init() performs a check using an hardcoded
>> mask on cpu_id.
>>
>> Create an interface to perform the check (that is now even easier to read).
>> Define also a proper mask (ARM_CPU_PART_MASK) that makes this kind of checks
>> cleaner and helps preventing bugs in the future. Update usage accordingly.
> 
> [...]
> 
> Tested-by: Kevin Hilman <khilman@...aro.org>
> 

Great, thanks!

> FWIW, I can confirm that this patch is needed for cpuidle-big_little to
> work on the Exynos5800/Chromebook2.
> 

Ok, the patch has been already sent to Russell's patch system.

Best,

- Juri

> Kevin
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/