linux-kernel - Re: [PATCH] module: Clean up ro/nx after early module load failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALCETrUxfxNv5E1=Fo8TGEwBeb=7Xz6ZcZHKouon=wh5iMuScw@mail.gmail.com>
Date:	Fri, 15 Aug 2014 12:26:52 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] module: Clean up ro/nx after early module load failures

On Fri, Aug 15, 2014 at 11:49 AM, Rusty Russell <rusty@...tcorp.com.au> wrote:
> Andy Lutomirski <luto@...capital.net> writes:
>> The commit
>>
>>     4982223e51e8 module: set nx before marking module MODULE_STATE_COMING.
>>
>> introduced a regression: if a module fails to parse its arguments or
>> if mod_sysfs_setup fails, then the module's memory will be freed
>> while still read-only.  Anything that reuses that memory will crash
>> as soon as it tries to write to it.
>
> Thanks, good catch.

Catching it was easy.  Figuring out wtf was happening to my poor
computer, on the other hand... :)

>
> Applied,
> Rusty.



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/