linux-kernel - Re: [PATCH] module: Clean up ro/nx after early module load failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ha1d8u6o.fsf@rustcorp.com.au>
Date:	Sat, 16 Aug 2014 04:19:19 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Andy Lutomirski <luto@...capital.net>, linux-kernel@...r.kernel.org
Cc:	Andy Lutomirski <luto@...capital.net>, stable@...r.kernel.org
Subject: Re: [PATCH] module: Clean up ro/nx after early module load failures

Andy Lutomirski <luto@...capital.net> writes:
> The commit
>
>     4982223e51e8 module: set nx before marking module MODULE_STATE_COMING.
>
> introduced a regression: if a module fails to parse its arguments or
> if mod_sysfs_setup fails, then the module's memory will be freed
> while still read-only.  Anything that reuses that memory will crash
> as soon as it tries to write to it.

Thanks, good catch.

Applied,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/