linux-kernel - Re: [PATCH] earlyprintk: re-enable earlyprintk calling early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lhqp8uvu.fsf@rustcorp.com.au>
Date:	Sat, 16 Aug 2014 04:04:13 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	kpark3469@...il.com, akpm@...ux-foundation.org
Cc:	keun-o.park@...driver.com, hpa@...or.com,
	rafael.j.wysocki@...el.com, peterz@...radead.org,
	kirill.shutemov@...ux.intel.com, oleg@...hat.com,
	prarit@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] earlyprintk: re-enable earlyprintk calling early_param

kpark3469@...il.com writes:
> From: Sahara <keun-o.park@...driver.com>
>
> Although there are many obs_kernel_param and its names are
> earlyprintk and also EARLY_PRINTK is also enabled, we could not
> see the early_printk output properly until now. This patch
> considers earlycon as well as earlyprintk.

Hmm, the initial "earlycon" hack slipped in when I wasn't looking.
I don't think we should extend it.

Why not make the thing(s) you want early_param()s?

Cheers,
Rusty.

> --- a/init/main.c
> +++ b/init/main.c
> @@ -426,7 +426,8 @@ static int __init do_early_param(char *param, char *val, const char *unused)
>  	for (p = __setup_start; p < __setup_end; p++) {
>  		if ((p->early && parameq(param, p->str)) ||
>  		    (strcmp(param, "console") == 0 &&
> -		     strcmp(p->str, "earlycon") == 0)
> +		     ((strcmp(p->str, "earlycon") == 0) ||
> +		     (strcmp(p->str, "earlyprintk") == 0)))
>  		) {
>  			if (p->setup_func(val) != 0)
>  				pr_warn("Malformed early option '%s'\n", param);
> -- 
> 1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/