linux-kernel - Re: [PATCH] earlyprintk: re-enable earlyprintk calling early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53F16A32.50608@windriver.com>
Date:	Mon, 18 Aug 2014 11:51:30 +0900
From:	Sahara <keun-o.park@...driver.com>
To:	Andrew Morton <akpm@...ux-foundation.org>, <kpark3469@...il.com>
CC:	<hpa@...or.com>, <rafael.j.wysocki@...el.com>,
	<peterz@...radead.org>, <rusty@...tcorp.com.au>,
	<kirill.shutemov@...ux.intel.com>, <oleg@...hat.com>,
	<prarit@...hat.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] earlyprintk: re-enable earlyprintk calling early_param


2014년 08월 15일 05:34, Andrew Morton 쓴 글:
> On Thu, 14 Aug 2014 19:13:36 +0900 kpark3469@...il.com wrote:
>
>> From: Sahara <keun-o.park@...driver.com>
>>
>> Although there are many obs_kernel_param and its names are
>> earlyprintk and also EARLY_PRINTK is also enabled, we could not
>> see the early_printk output properly until now. This patch
>> considers earlycon as well as earlyprintk.
> Sorry, I just don't understand this description.
>
> What does the patch actually do?  What was the kernel behaviour without
> the patch and what is the kernel behaviour with the patch?
>
Without this patch,
- earlycon case -
if early_param("earlycon", ...) is defined and
case #1: if cmdline has "earlycon", then it satisfies the condition 
"(p->early && parameq(param, p->str))". You can see early_printk().
case #2: if cmdline has "console", then it satisfies the condition 
"strcmp(param, "console") == 0 && strcmp(p->str, "earlycon") == 0". You 
can see early_printk().

- earlyprintk case -
if early_param("earlyprintk", ...) is defined and
case #1: if cmdline has "earlyprintk", then it satisfies the condition 
"(p->early && parameq(param, p->str))". You can see early_printk().
case #2: if cmdline has "console", it does not satisfies the condition, 
because it only checks out "earlycon" only.

This patch fixes the case #2 problem of earlyprintk.

Thanks.

Best Regards,
Sahara.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/