linux-kernel - Re: [PATCH v1 01/12] dmaengine: dw: move dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Aug 2014 12:28:20 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Hans-Christian Egtvedt <egtvedt@...fundet.no>,
	Haavard Skinnemoen <hskinnemoen@...il.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Mark Brown <broonie@...nel.org>,
	Hein Tibosch <hein_tibosch@...oo.es>,
	Russell King <linux@....linux.org.uk>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Takashi Iwai <tiwai@...e.de>,
	Kweh Hock Leong <hock.leong.kweh@...el.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Alan Cox <alan@...ux.intel.com>, dmaengine@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 01/12] dmaengine: dw: move dw_dmac.h to where it
 belongs to


On Wed, 2014-08-20 at 14:25 +0530, Viresh Kumar wrote:
> On Tue, Aug 19, 2014 at 10:59 PM, Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > There is a common storage for platform data related structures and definitions
> > inside kernel source tree. The patch moves file from include/linux to
> > include/linux/platform_data and renames it acoordingly. The users are also
> > updated.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> 
> >  include/linux/dw_dmac.h                         | 111 ------------------------
> >  include/linux/platform_data/dma-dw.h            | 111 ++++++++++++++++++++++++
> 
> Nice work but wrong git commands to produce this patch..
> Always run format-patch with these options Atleast:
> 
> git format-patch -C -M --thread=shallow
> 
> With the -C -M option you would have got something like:
> 
>  include/linux/{dw_dmac.h => platform_data/dma-dw.h} | 0
> 
> Which would have made review so so easy :)

Thanks for reminding me this, though I thought I would do that way and
*forgot* while rebasing series.

And thanks for Ack!


-- 
Andy Shevchenko <andriy.shevchenko@...el.com>
Intel Finland Oy

-- 
Andy Shevchenko <andriy.shevchenko@...el.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/