linux-kernel - Re: [PATCH 1/9] KVM: add kvm_arch_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140820125656.GE28873@potion.brq.redhat.com>
Date:	Wed, 20 Aug 2014 14:56:57 +0200
From:	Radim Krčmář <rkrcmar@...hat.com>
To:	Christian Borntraeger <borntraeger@...ibm.com>
Cc:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Paolo Bonzini <pbonzini@...hat.com>,
	Gleb Natapov <gleb@...nel.org>,
	Raghavendra KT <raghavendra.kt@...ux.vnet.ibm.com>,
	Vinod Chegu <chegu_vinod@...com>, Hui-Zhi <hui-zhi.zhao@...com>
Subject: Re: [PATCH 1/9] KVM: add kvm_arch_sched_in

2014-08-20 09:47+0200, Christian Borntraeger:
> On 19/08/14 22:35, Radim Krčmář wrote:
> 
> > --- a/virt/kvm/kvm_main.c
> > +++ b/virt/kvm/kvm_main.c
> > @@ -3123,6 +3123,8 @@ static void kvm_sched_in(struct preempt_notifier *pn, int cpu)
> >  	if (vcpu->preempted)
> >  		vcpu->preempted = false;
> > 
> > +	kvm_arch_sched_in(vcpu, cpu);
> > +
> >  	kvm_arch_vcpu_load(vcpu, cpu);
> >  }
> > 
> 
> Why cant you reuse kvm_arch_vcpu_load? Its also called on each sched_in and is architecture specific.

kvm_arch_vcpu_load is also called from kvm_vcpu_ioctl, so we'd be
shrinking unnecessarily.
(sched_in gives us a bit of useful information about the state of the
 system, kvm_vcpu_ioctl not that much.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/