linux-kernel - Re: [PATCH v3 12/13] pmcraid: Get rid of a redundant assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53F5D920.1080800@redhat.com>
Date:	Thu, 21 Aug 2014 13:33:52 +0200
From:	Tomas Henzl <thenzl@...hat.com>
To:	Alexander Gordeev <agordeev@...hat.com>,
	linux-kernel@...r.kernel.org
CC:	Anil Ravindranath <anil_ravindranath@...-sierra.com>,
	linux-scsi@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH v3 12/13] pmcraid: Get rid of a redundant assignment

On 08/18/2014 08:01 AM, Alexander Gordeev wrote:
> Signed-off-by: Alexander Gordeev <agordeev@...hat.com>
> Cc: Anil Ravindranath <anil_ravindranath@...-sierra.com>
> Cc: linux-scsi@...r.kernel.org
> Cc: linux-pci@...r.kernel.org
> ---
>  drivers/scsi/pmcraid.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> index 6f3275d..6e575ed 100644
> --- a/drivers/scsi/pmcraid.c
> +++ b/drivers/scsi/pmcraid.c
> @@ -4746,7 +4746,6 @@ pmcraid_isr_legacy:
>  	pinstance->hrrq_vector[0].drv_inst = pinstance;
>  	pinstance->hrrq_vector[0].vector = pdev->irq;
>  	pinstance->num_hrrq = 1;
> -	rc = 0;
>  
>  	rc = request_irq(pdev->irq, pmcraid_isr, IRQF_SHARED,
>  			 PMCRAID_DRIVER_NAME, &pinstance->hrrq_vector[0]);

Patch looks good to me.

Reviewed-by: Tomas Henzl <thenzl@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/