linux-kernel - Re: [PATCH 2/4] mfd: arizona: Propagate irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140821115750.GB4266@lee--X1>
Date:	Thu, 21 Aug 2014 12:57:50 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	sameo@...ux.intel.com, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] mfd: arizona: Propagate irq_wake through to parent
 IRQ

On Tue, 12 Aug 2014, Charles Keepax wrote:

> If one of the internal Arizona IRQs is set as a wake source this needs
> to be propogated back to the actual IRQ line that the Arizona device is
> attached to.
> 
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
>  drivers/mfd/arizona-irq.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)

Acked-by: Lee Jones <lee.jones@...aro.org>

... but obviously this won't apply, as it's based on the previous
NACKed patch.

> diff --git a/drivers/mfd/arizona-irq.c b/drivers/mfd/arizona-irq.c
> index 71e8f06..fac00b2 100644
> --- a/drivers/mfd/arizona-irq.c
> +++ b/drivers/mfd/arizona-irq.c
> @@ -148,6 +148,13 @@ static void arizona_irq_dummy(struct irq_data *data)
>  {
>  }
>  
> +static int arizona_irq_set_wake(struct irq_data *data, unsigned int on)
> +{
> +	struct arizona *arizona = irq_data_get_irq_chip_data(data);
> +
> +	return irq_set_irq_wake(arizona->irq, on);
> +}
> +
>  static struct irq_chip arizona_irq_chip = {
>  	.name			= "arizona",
>  	.irq_disable		= arizona_irq_dummy,
> @@ -155,6 +162,7 @@ static struct irq_chip arizona_irq_chip = {
>  	.irq_ack		= arizona_irq_dummy,
>  	.irq_mask		= arizona_irq_dummy,
>  	.irq_unmask		= arizona_irq_dummy,
> +	.irq_set_wake		= arizona_irq_set_wake,
>  };
>  
>  static int arizona_irq_map(struct irq_domain *h, unsigned int virq,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/