linux-kernel - Re: [PATCH v2 1/6] KVM: add kvm_arch_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Aug 2014 15:25:26 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Radim Krčmář <rkrcmar@...hat.com>
CC:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Gleb Natapov <gleb@...nel.org>,
	Raghavendra KT <raghavendra.kt@...ux.vnet.ibm.com>,
	Vinod Chegu <chegu_vinod@...com>,
	Hui-Zhi <hui-zhi.zhao@...com>,
	Christian Borntraeger <borntraeger@...ibm.com>
Subject: Re: [PATCH v2 1/6] KVM: add kvm_arch_sched_in

Il 21/08/2014 14:50, Radim Krčmář ha scritto:
> > > 
> > > All empty arch functions are in '.c' files, so it seems better to follow
> > > the same path.
> > > (And have one refactoring patch if GCC does not optimize this.)
> > 
> > GCC certainly does not optimize this (unless you use LTO).
> 
> I see LTO patches in next ... do we want to move every empty arch
> function into headers?

I wouldn't reject the patches.

(It would also save some lines of code, since in the headers it's common
to do "static inline void foo(void) {}" on a single line).

> (It is probably going to take LTO few years to be enabled by default.)

Indeed...  see also
http://lwn.net/SubscriberLink/608945/7763ad2aee106f1d/ from today's LWN
issue.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/