linux-kernel - Re: [PATCH 1/3] usb: add support for Diolan DLN-2 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE1zotJBB=wxx=v2_e4+O5KjBUhF++ER83rHO1R1zunDs7ksVg@mail.gmail.com>
Date:	Fri, 22 Aug 2014 02:10:40 +0300
From:	Octavian Purdila <octavian.purdila@...el.com>
To:	Johan Hovold <johan@...nel.org>
Cc:	Daniel Baluta <daniel.baluta@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, wsa@...-dreams.de,
	linux-i2c@...r.kernel.org, linus.walleij@...aro.org,
	gnurou@...il.com, linux-gpio@...r.kernel.org,
	pratyush.anand@...com, pebolle@...cali.nl,
	Alan Stern <stern@...land.harvard.edu>, matthew@...systems.ca,
	lkml <linux-kernel@...r.kernel.org>,
	Laurentiu Palcu <laurentiu.palcu@...el.com>, jdelvare@...e.de,
	arnd@...db.de, sjg@...omium.org
Subject: Re: [PATCH 1/3] usb: add support for Diolan DLN-2 devices

On Thu, Aug 21, 2014 at 11:07 AM, Johan Hovold <johan@...nel.org> wrote:
> On Wed, Aug 20, 2014 at 02:24:45PM +0300, Daniel Baluta wrote:
>> From: Octavian Purdila <octavian.purdila@...el.com>
>>
>> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO
>> Master Adapter DLN-2. Details about the device can be found here:
>>
<snip>
>
> I think you want to implement this driver as an MFD driver, rather than
> invent your own module registration.
>

Hi Johan,

Thank you for the detailed reviewed. We will rewrite the drivers to
use the MFD interface and address the rest of your comments and we
will resubmit them next week.

Thanks,
Tavi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/