linux-kernel - Re: [PATCH 3/3] gpio: add support for the Diolan DLN-2 USB-GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaZcpTXiNZNKFeQgESxtYqKC+gR-VYbxoORYrykGUWRVw@mail.gmail.com>
Date:	Fri, 29 Aug 2014 09:16:17 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Daniel Baluta <daniel.baluta@...el.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	Wolfram Sang <wsa@...-dreams.de>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"pratyush.anand@...com" <pratyush.anand@...com>,
	Paul Bolle <pebolle@...cali.nl>,
	Alan Stern <stern@...land.harvard.edu>,
	octavian.purdila@...el.com, matthew@...systems.ca,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	laurentiu.palcu@...el.com, Jean Delvare <jdelvare@...e.de>,
	Arnd Bergmann <arnd@...db.de>, Simon Glass <sjg@...omium.org>
Subject: Re: [PATCH 3/3] gpio: add support for the Diolan DLN-2 USB-GPIO driver

On Wed, Aug 20, 2014 at 1:24 PM, Daniel Baluta <daniel.baluta@...el.com> wrote:

> This patch adds GPIO and IRQ support for the Diolan DLN-2 GPIO module.
>
> Information about the USB protocol interface can be found in the
> Programmer's Reference Manual [1], see section 2.9 for the GPIO
> module commands and responses.
>
> [1] https://www.diolan.com/downloads/dln-api-manual.pdf
>
> Signed-off-by: Daniel Baluta <daniel.baluta@...el.com>

Major change required: rewrite this driver to not select IRQ_DOMAIN,
instead select GPIOLIB_IRQCHIP and use the shared infrastructure.
See other drivers that select GPIOLIB_IRQCHIP or grep the git
log to see how this works in practice.

You need to use some container_of() operations.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/