[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140822052926.GM4120@two.firstfloor.org>
Date: Fri, 22 Aug 2014 07:29:26 +0200
From: Andi Kleen <andi@...stfloor.org>
To: "Yan, Zheng" <zheng.z.yan@...el.com>
Cc: linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
mingo@...nel.org, acme@...radead.org, eranian@...gle.com,
andi@...stfloor.org
Subject: Re: [PATCH 1/2] perf/x86/intel: Add Haswell-EP uncore support
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> index 4785ee8..2485fd9 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> @@ -883,6 +883,8 @@ static int __init uncore_pci_init(void)
> case 62: /* Ivy Bridge-EP */
> ret = ivbep_uncore_pci_init();
> break;
> + case 63: /* Haswell-EP */
> + ret = hswep_uncore_pci_init();
Is the lack of break intentional? If yes please add a /* FALL THROUGH */
comment.
> case 42: /* Sandy Bridge */
> ret = snb_uncore_pci_init();
> break;
>
--
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists