linux-kernel - Re: [PATCH] drm/exynos/fbdev: set smem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87siklzivw.fsf@sushi.unix-ag.uni-kl.de>
Date:	Sun, 24 Aug 2014 23:18:27 +0200
From:	Günther Noack <guenther@...x-ag.uni-kl.de>
To:	Daniel Kurtz <djkurtz@...omium.org>,
	Inki Dae <inki.dae@...sung.com>,
	Siarhei Siamashka <siarhei.siamashka@...il.com>,
	Günther Noack <me@...nthernoack.de>
Cc:	Joonyoung Shim <jy0922.shim@...sung.com>,
	Seung-Woo Kim <sw0312.kim@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Daniel Kurtz <djkurtz@...omium.org>
Subject: Re: [PATCH] drm/exynos/fbdev: set smem_len for fbdev


This patch works on my hardware.  Xorg starts up fine with fbdev now.
Thanks for the fix!

--Günther

Daniel Kurtz <djkurtz@...omium.org> writes:

> Commit [0] stopped setting fix.smem_start and fix.smem_len when creating
> the fbdev.
>
> [0] 2f1eab8d8ab59e799f7d51d62410b398607a7bc3
>   drm/exynos/fbdev: don't set fix.smem/mmio_{start,len}
>
> However, smem_len is used by some userland applications to calculate the
> size for mmap.  In particular, it is used by xf86-video-fbdev:
>
> http://cgit.freedesktop.org/xorg/xserver/tree/hw/xfree86/fbdevhw/fbdevhw.c?id=xorg-server-1.15.99.903#n571
>
> So, let's restore setting the smem_len to unbreak things for these users.
>
> Note: we are still leaving smem_start set to 0.
>
> Reported-by: Siarhei Siamashka <siarhei.siamashka@...il.com>
> Reported-by: Günther Noack <me@...nthernoack.de>
> Signed-off-by: Daniel Kurtz <djkurtz@...omium.org>
> ---
> I am able to compile test this change, but would appreciate help testing it
> on a system that uses xf86-video-fbdev.
>
> Thanks!
>
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> index 5a7cd8b..f865736 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> @@ -125,6 +125,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
>  
>  	fbi->screen_base = buffer->kvaddr;
>  	fbi->screen_size = size;
> +	fbi->fix.smem_len = size;
>  
>  	return 0;
>  }
> -- 
> 2.1.0.rc2.206.gedb03e5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/