lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 24 Aug 2014 23:20:55 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Hayes Wang <hayeswang@...ltek.com>
Cc:	netdev@...r.kernel.org, nic_swsd@...ltek.com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH net-next 4/4] r8152: support firmware files

Hayes Wang <hayeswang@...ltek.com> :
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 937d132..63542cc 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
[...]
> +static void rtl_request_firmware(struct r8152 *tp)
> +{
> +	char *fw_name = NULL;
> +
> +	if (tp->rtl_fw.fw)
> +		goto out_request;
> +
> +	switch (tp->version) {
> +	case RTL_VER_01:
> +		fw_name = "rtl_nic/rtl8152-1.fw";
> +		break;
> +	case RTL_VER_02:
> +		fw_name = "rtl_nic/rtl8152-2.fw";
> +		break;
> +	case RTL_VER_03:
> +		fw_name = "rtl_nic/rtl8153-1.fw";
> +		break;
> +	case RTL_VER_04:
> +		fw_name = "rtl_nic/rtl8153-2.fw";
> +		break;
> +	case RTL_VER_05:
> +		fw_name = "rtl_nic/rtl8153-3.fw";
> +		break;

The driver should use MODULE_FIRMWARE() for these files.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists