linux-kernel - Re: [GIT PULL] nohz: Fix double clock write on idle ticks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140824144559.GA9455@gmail.com>
Date:	Sun, 24 Aug 2014 16:45:59 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Preeti U Murthy <preeti@...ux.vnet.ibm.com>
Subject: Re: [GIT PULL] nohz: Fix double clock write on idle ticks


* Frederic Weisbecker <fweisbec@...il.com> wrote:

> Le dimanche 24 août 2014, Ingo Molnar <mingo@...nel.org> a écrit :
> 
> > * Frederic Weisbecker <fweisbec@...il.com <javascript:;>> wrote:
> >
> > > From: Frederic Weisbecker <fweisbec@...il.com <javascript:;>>
> > >
> > > Ingo,
> > >
> > > Please pull the nohz/drop-double-write-v3 branch that can be found at:
> > >
> > > git://
> > git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> > >       nohz/drop-double-write-v3
> > >
> > > Although the 1st patch fixes a bug, it was a longstanding issue so
> > > that branch doesn't need to be applied in 3.17. The next merge window
> > > looks better.
> > >
> > > --
> > > The tick reschedules itself unconditionally. It's relevant in periodic
> > > mode but not in dynticks mode where it results in spurious double clock
> > > writes and even spurious periodic behaviour for low-res case.
> > >
> > > This set fixes that:
> > >
> > > * 1st patch removes low-res periodic tick rescheduling in nohz mode.
> > > This fixes spurious periodic behaviour.
> > >
> > > * 2nd patch does the same for high-res mode. Here there is no such
> > > spurious periodic behaviour but it still spares a double clock write
> > > in some cases.
> > > ---
> > >
> > >
> > > Thanks,
> > >       Frederic
> > > ---
> > >
> > > Viresh Kumar (2):
> > >       nohz: Fix spurious periodic tick behaviour in low-res dynticks mode
> > >       nohz: Avoid tick's double reprogramming in highres mode
> > >
> > >
> > >  kernel/time/tick-sched.c | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> >
> > > These fixes are pretty small - any objections
> 
> > against putting it into
> > > timers/urgent and including it in v3.17?
> 
> 
> OK sounds good to me. They are easily reverted if any problem arises.

On a second thought, 'spurious periodic behavior' is really just 
sub-optimal full-nohz behavior - it's not an outright 
user-noticeable bug, correct?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/