linux-kernel - Re: [PATCH 1/2] HID: logitech-dj: prevent false errors to be shown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1408250300030.23162@pobox.suse.cz>
Date:	Mon, 25 Aug 2014 03:00:18 -0500 (CDT)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Markus Trippelsdorf <markus@...ppelsdorf.de>
cc:	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ben Hawkes <hawkes@...gle.com>
Subject: Re: [PATCH 1/2] HID: logitech-dj: prevent false errors to be shown

On Mon, 25 Aug 2014, Markus Trippelsdorf wrote:

> > > Commit "HID: logitech: perform bounds checking on device_id early
> > > enough" unfortunately leaks some errors to dmesg which are not real
> > > ones:
> > > - if the report is not a DJ one, then there is not point in checking
> > >   the device_id
> > > - the receiver (index 0) can also receive some notifications which
> > >   can be safely ignored given the current implementation
> > > 
> > > Move out the test regarding the report_id and also discards
> > > printing errors when the receiver got notified.
> > > 
> > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> > 
> > I have now queued this one for 3.17. Adding Markus to CC -- Markus, this 
> > should make the spurious error messages you have reported go away.
> 
> Indeed it does. Feel free to add:
> 
> Reported-and-tested-by: Markus Trippelsdorf <markus@...ppelsdorf.de>

Excellent, thanks. Will be pushing it to Linus this week.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/