linux-kernel - Re: [PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '?' errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Aug 2014 06:15:19 -0700
From:	Joe Perches <joe@...ches.com>
To:	Greg Donald <gdonald@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8821ae: Fix spaces required around
 that '?' errors

On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote:
> Fix checkpatch.pl spaces required around that '?' errors

It'd be better to convert all parts of the
ternary at the same time.

> diff --git a/drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c b/drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c
[]
> @@ -652,7 +652,7 @@ halbtc8812a1ant_SetFwDecBtPwr(
>  	u1Byte	buf[5] = {0};
>  
>  	BTC_PRINT(BTC_MSG_ALGORITHM, ALGO_TRACE_FW_EXEC, ("[BTCoex], decrease Bt Power : %s\n", 
> -			(dec_bt_pwr? "Yes!!":"No!!")));
> +			(dec_bt_pwr ? "Yes!!":"No!!")));

		    (dec_bt_pwr ? "Yes!!" : "No!!")
			
>  
>  	buf[0] = dataLen;
>  	buf[1] = 0x3;		// OP_Code
> @@ -674,7 +674,7 @@ halbtc8812a1ant_DecBtPwr(
>  {
>  	return;
>  	BTC_PRINT(BTC_MSG_ALGORITHM, ALGO_TRACE_FW, ("[BTCoex], %s Dec BT power = %s\n",  
> -		(force_exec? "force to":""), ((dec_bt_pwr)? "ON":"OFF")));
> +		(force_exec ? "force to":""), ((dec_bt_pwr) ? "ON":"OFF")));

		    (force_exec ? "force to" : ""), ((dec_bt_pwr) ? "ON" : "OFF")));

etc...

A subsequent change might be to remove the unnecessary
parentheses like:

		    force_exec ? "force to" : "", dec_bt_pwr ? "ON" : "OFF");


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/