| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Aug 2014 08:51:25 -0500 From: Greg Donald <gdonald@...il.com> To: Joe Perches <joe@...ches.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '?' errors On Mon, Aug 25, 2014 at 8:15 AM, Joe Perches <joe@...ches.com> wrote: > On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote: >> Fix checkpatch.pl spaces required around that '?' errors > > It'd be better to convert all parts of the > ternary at the same time. Wouldn't "at the same time" be in direct conflict with the "only do one thing per patch" rule? > (force_exec ? "force to" : ""), ((dec_bt_pwr) ? "ON" : "OFF"))); > > etc... > > A subsequent change might be to remove the unnecessary > parentheses like: > > force_exec ? "force to" : "", dec_bt_pwr ? "ON" : "OFF"); I understand. It's very likely I'll submit such a patch in the future. I'm currently attempting to keep my cleanups to a single error/warning type so I get as much done as possible per patch while also keeping the patch easy to review. Is this wrong? -- Greg Donald -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists