| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <53FBA416.7060406@gmail.com>
Date: Mon, 25 Aug 2014 23:01:10 +0200
From: Marcin Jabrzyk <marcin.jabrzyk@...il.com>
To: Mathieu Poirier <mathieu.poirier@...aro.org>
CC: Linus Walleij <linus.walleij@...aro.org>,
Will Deacon <will.deacon@....com>,
Russell King - ARM Linux <linux@....linux.org.uk>,
00regkh@...uxfoundation.org, Pratik Patel <pratikp@...eaurora.org>,
Vikas Varshney <varshney@...com>, Al Grant <Al.Grant@....com>,
Jonas Svennebring <jonas.svennebring@...gotech.com>,
James King <james.king@...aro.org>,
Panchaxari Prasannamurthy Tumkur
<panchaxari.prasannamurthy@...aro.org>,
Kaixu Xia <kaixu.xia@...aro.org>,
"r.sengupta@...sung.com" <r.sengupta@...sung.com>,
Robert Marklund <robbelibobban@...il.com>,
Tony Armitstead <Tony.Armitstead@....com>,
Daniel Thompson <daniel.thompson@...aro.org>,
Patch Tracking <patches@...aro.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 09/11 v4] coresight: adding support for beagle and beagleXM
Hello,
W dniu 25.08.2014 o 16:02, Mathieu Poirier pisze:
> On 24 August 2014 15:38, Marcin Jabrzyk <marcin.jabrzyk@...il.com> wrote:
>> Hi,
>>
>> W dniu 20.08.2014 o 19:03, mathieu.poirier@...aro.org pisze:
>>> From: Mathieu Poirier <mathieu.poirier@...aro.org>
>>>
>>> Currently supporting ETM and ETB. Support for TPIU
>>> and SDTI are yet to be added.
>> Did you tried running the drivers on board or are there any special
>> preparation needed?
>> I've BeagleBoard-xM Rev. C applied your patches and enabled the
>> functions the in menuconfig.
>> But on dmesg I see that:
>>
>> [ 0.685028] of_amba_device_create(): amba_device_add() failed (-19)
>> for /etb@...1b000
>> [ 0.685119] of_amba_device_create(): amba_device_add() failed (-19)
>> for /etm@...10000
>>
>> There are no nodes according coresight in /sys/kernel/debug/ .
> Right, that is because there is a problem in mainline with enabling
> "emu_src_ck". The call to "clk_prepare_enable()" returns without
> waiting for the clock to effectively be enabled, preventing the
> components from being discovered properly.
>
> The work around (non-upstreamable) is to have a driver getting a hold
> of the clock before AMBA devices are probed. I can send you that code
> (10 lines) if need be.
Ok I can confirm that this patch works fine for BeagleBoard-xM. After
applying workaround for that clock the devices are properly discovered
and visible through sysfs entries.
Thanks,
Marcin
>
>> Best regards,
>> Marcin
>>
>>> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
>>> ---
>>> arch/arm/boot/dts/omap3-beagle-xm.dts | 28 ++++++++++++++++++++++++++++
>>> arch/arm/boot/dts/omap3-beagle.dts | 28 ++++++++++++++++++++++++++++
>>> 2 files changed, 56 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
>>> index 1becefc..eec73d8 100644
>>> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
>>> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
>>> @@ -145,6 +145,34 @@
>>> };
>>> };
>>> };
>>> +
>>> + etb@...1b000 {
>>> + compatible = "arm,coresight-etb10", "arm,primecell";
>>> + reg = <0x5401b000 0x1000>;
>>> +
>>> + coresight-default-sink;
>>> + clocks = <&emu_src_ck>;
>>> + clock-names = "apb_pclk";
>>> + port {
>>> + etb_in: endpoint {
>>> + slave-mode;
>>> + remote-endpoint = <&etm_out>;
>>> + };
>>> + };
>>> + };
>>> +
>>> + etm@...10000 {
>>> + compatible = "arm,coresight-etm3x", "arm,primecell";
>>> + reg = <0x54010000 0x1000>;
>>> +
>>> + clocks = <&emu_src_ck>;
>>> + clock-names = "apb_pclk";
>>> + port {
>>> + etm_out: endpoint {
>>> + remote-endpoint = <&etb_in>;
>>> + };
>>> + };
>>> + };
>>> };
>>>
>>> &omap3_pmx_wkup {
>>> diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts
>>> index 3c3e6da..a151daf 100644
>>> --- a/arch/arm/boot/dts/omap3-beagle.dts
>>> +++ b/arch/arm/boot/dts/omap3-beagle.dts
>>> @@ -140,6 +140,34 @@
>>> };
>>> };
>>> };
>>> +
>>> + etb@...000000 {
>>> + compatible = "arm,coresight-etb10", "arm,primecell";
>>> + reg = <0x5401b000 0x1000>;
>>> +
>>> + coresight-default-sink;
>>> + clocks = <&emu_src_ck>;
>>> + clock-names = "apb_pclk";
>>> + port {
>>> + etb_in: endpoint {
>>> + slave-mode;
>>> + remote-endpoint = <&etm_out>;
>>> + };
>>> + };
>>> + };
>>> +
>>> + etm@...10000 {
>>> + compatible = "arm,coresight-etm3x", "arm,primecell";
>>> + reg = <0x54010000 0x1000>;
>>> +
>>> + clocks = <&emu_src_ck>;
>>> + clock-names = "apb_pclk";
>>> + port {
>>> + etm_out: endpoint {
>>> + remote-endpoint = <&etb_in>;
>>> + };
>>> + };
>>> + };
>>> };
>>>
>>> &omap3_pmx_wkup {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists