linux-kernel - Re: [PATCH] sound: pci: ctxfi: prink replacement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hr4035ymf.wl-tiwai@suse.de>
Date:	Tue, 26 Aug 2014 12:33:28 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: pci: ctxfi: prink replacement

At Tue, 26 Aug 2014 15:43:24 +0530,
Sudip Mukherjee wrote:
> 
> printk replaced with corresponding pr_err and pr_alert
> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
> 
> Initially started by copy-paste but as Takashi suggested it was done by a script.
> bash script is as follows :
> 
> OLD="printk(KERN_ERR \?"
> OLD1="printk(KERN_ALERT \?"
> NEW="pr_err("
> NEW1="pr_alert("
> TFILE="/tmp/out.tmp.$$"
> for f in *.c
> do
> sed "s/$OLD/$NEW/g" "$f" > $TFILE && mv $TFILE "$f"
> sed "s/$OLD1/$NEW1/g" "$f" > $TFILE && mv $TFILE "$f"
> done

All these can be a single call of sed :)

> this patch will generate a warning from checkpatch for an unnecessary space before new line and has not been fixed as this patch is only for printk replacement.

Better to put such information into the changelog.

Do you have the patch reformatting the broken lines, too?
If yes, I'll wait for it, as we should apply both such patches at
once.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/