linux-kernel - Re: [PATCH V2] video : remove redundant error check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53FC629A.2050101@ti.com>
Date:	Tue, 26 Aug 2014 13:34:02 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Daeseok Youn <daeseok.youn@...il.com>, <plagnioj@...osoft.com>,
	Antonino Daplas <adaplas@...il.com>
CC:	<jg1.han@...sung.com>, <laurent.pinchart@...asonboard.com>,
	<robdclark@...il.com>, <daniel.vetter@...ll.ch>,
	<Julia.Lawall@...6.fr>, <linux-fbdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] video : remove redundant error check

On 16/05/14 12:31, Daeseok Youn wrote:
> It doesn't need to check "err" for printing info.
> And also use pr_info instead of printk.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
> ---
> V2: removes unneeded lines for sending a patch
> 
>  drivers/video/fbdev/i810/i810_main.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
> index bb674e4..15cb397 100644
> --- a/drivers/video/fbdev/i810/i810_main.c
> +++ b/drivers/video/fbdev/i810/i810_main.c
> @@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info *info)
>  
>  	for (i = 0; i < par->ddc_num + 1; i++) {
>  		err = i810_probe_i2c_connector(info, &par->edid, i);
> -		if (!err)
> +		if (!err) {
> +			pr_info("i810fb_init_pci: DDC probe successful\n");
>  			break;
> +		}
>  	}
>  
> -	if (!err)
> -		printk("i810fb_init_pci: DDC probe successful\n");
> -
>  	fb_edid_to_monspecs(par->edid, specs);
>  
>  	if (specs->modedb == NULL)
> 

I don't know... I think I personally like more the original version. In
fact, the whole print looks quite useless to me, or at least it should
be a debug print.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)