linux-kernel - Re: [PATCH V2] video : remove redundant error check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHb8M2C4FygA5k9bPbuoJTv1EWZ-iGZrD7X7jrHoVqH=_L-_+Q@mail.gmail.com>
Date:	Wed, 27 Aug 2014 19:00:58 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Tomi Valkeinen <tomi.valkeinen@...com>
Cc:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	Antonino Daplas <adaplas@...il.com>, jg1.han@...sung.com,
	laurent.pinchart@...asonboard.com, Rob Clark <robdclark@...il.com>,
	daniel.vetter@...ll.ch, Julia Lawall <Julia.Lawall@...6.fr>,
	linux-fbdev@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] video : remove redundant error check

Hi,

2014-08-26 19:34 GMT+09:00 Tomi Valkeinen <tomi.valkeinen@...com>:
> On 16/05/14 12:31, Daeseok Youn wrote:
>> It doesn't need to check "err" for printing info.
>> And also use pr_info instead of printk.
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
>> ---
>> V2: removes unneeded lines for sending a patch
>>
>>  drivers/video/fbdev/i810/i810_main.c |    7 +++----
>>  1 files changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
>> index bb674e4..15cb397 100644
>> --- a/drivers/video/fbdev/i810/i810_main.c
>> +++ b/drivers/video/fbdev/i810/i810_main.c
>> @@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info *info)
>>
>>       for (i = 0; i < par->ddc_num + 1; i++) {
>>               err = i810_probe_i2c_connector(info, &par->edid, i);
>> -             if (!err)
>> +             if (!err) {
>> +                     pr_info("i810fb_init_pci: DDC probe successful\n");
>>                       break;
>> +             }
>>       }
>>
>> -     if (!err)
>> -             printk("i810fb_init_pci: DDC probe successful\n");
>> -
>>       fb_edid_to_monspecs(par->edid, specs);
>>
>>       if (specs->modedb == NULL)
>>
>
> I don't know... I think I personally like more the original version. In
> fact, the whole print looks quite useless to me, or at least it should
> be a debug print.
Yes. this patch doesn't need.

Thanks for review.

regards,
Daeseok Youn.
>
>  Tomi
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/