linux-kernel - Re: [PATCH] sound: pci: ctxfi: fix broken user-visible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hegw35t4r.wl-tiwai@suse.de>
Date:	Tue, 26 Aug 2014 14:32:04 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: pci: ctxfi: fix broken user-visible string

At Tue, 26 Aug 2014 17:52:14 +0530,
Sudip Mukherjee wrote:
> 
> fixed broken user visible strings

This text just repeats what the summary line says.  Instead, you
should write *why* the patch is needed.  Ditto for the previous
patch.

> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
> 
> I am not exactly sure about the patch as some lines after fixing has crossed the limit of 80 characters.
> But the coding style says :
> "never break user-visible strings such as printk messages, because that breaks the ability to grep for them"

Right, the 80 chars rule can be a guideline, it doesn't always force
the codes to fit within.  A long message string is clearly such a
case.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/