linux-kernel - RE: [PATCH V2] cgroup: Introduce cgroup_detach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91E2D863603AD4478F101CE81E76E45D01B5AA9A@SHSMSX103.ccr.corp.intel.com>
Date:	Tue, 26 Aug 2014 02:22:26 +0000
From:	"Ni, Xun" <xun.ni@...el.com>
To:	Dongsheng Yang <dongsheng081251@...il.com>,
	Li Zefan <lizefan@...wei.com>
CC:	Tejun Heo <tj@...nel.org>,
	Dongsheng Yang <yangds.fnst@...fujitsu.com>,
	"cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V2] cgroup: Introduce cgroup_detach_task().

Maybe your point can be added to the README or FAQ for cgroup. Try to shoot a patch for that, it will be more effective...

Thanks,
Xun

-----Original Message-----
From: cgroups-owner@...r.kernel.org [mailto:cgroups-owner@...r.kernel.org] On Behalf Of Dongsheng Yang
Sent: Tuesday, August 26, 2014 10:16 AM
To: Li Zefan
Cc: Tejun Heo; Dongsheng Yang; cgroups@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] cgroup: Introduce cgroup_detach_task().

On Tue, Aug 26, 2014 at 9:35 AM, Li Zefan <lizefan@...wei.com> wrote:
> On 2014/8/25 23:00, Dongsheng Yang wrote:
>> On Mon, Aug 25, 2014 at 10:47 PM, Tejun Heo <tj@...nel.org> wrote:
>>> On Mon, Aug 25, 2014 at 10:46:03PM +0800, Dongsheng Yang wrote:
>>>> My point here is that attaching and detaching are a pair of operations.
>>>
>>> There is no detaching from a cgroup.  A task is always attached to a 
>>> cgroup whether that's a root or non-root cgroup.
>>
>> Okey, I should not think it as attaching and detaching. Just treat 
>> them as a move between root and non-root cgroup.
>>
>> It sounds reasonable to me now.
>>
>
> I from time to time have to explain this to other people.

Ha, we usually want to find a detach function when we saw a function named as cgroup_attach_task().
>
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@...r.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html