linux-kernel - Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Aug 2014 23:53:56 -0700
From:	Nicolin Chen <nicoleotsuka@...il.com>
To:	"Li.Xiubo@...escale.com" <Li.Xiubo@...escale.com>
Cc:	Mark Rutland <mark.rutland@....com>,
	"broonie@...nel.org" <broonie@...nel.org>,
	"timur@...i.org" <timur@...i.org>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"perex@...ex.cz" <perex@...ex.cz>, "tiwai@...e.de" <tiwai@...e.de>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

On Tue, Aug 26, 2014 at 7:12 PM, Li.Xiubo@...escale.com
<Li.Xiubo@...escale.com> wrote:
> > > This property used for configuring whether the LSB or the MSB is transmitted
> > > first for the fifo data.
> >
> > I don't follow the rationale for this change.
> >
> > This looks like a pointless renaming.
> >
> > Why is this any better?
> >
>
> This is originally to indicate whether the LSB firstly or MSB firstly will be
> transmitted to the CODEC or received from the CODEC, and there has nothing
> Relation to the memory data.
>
> Generally, if the audio data in big endian format, which will be using the bytes
> Reversion ? Here this can only be used to bits reversion.

That's why I suggested previously: mention it in the commit comment.

People will have no idea about what's the exact reason for this change.
Any functional enhancement? Or a bug fix(more likely for this one).
I'm not sure what I described in the previous mail is correct or not.
But you probably should have added it into the commit comments.

And Xiubo, this patch still hasn't fixed the issue of breaking the old DT,
although system can pass during the probe() section.

Thank you,
Nicolin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/