linux-kernel - Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140827070544.GO17528@sirena.org.uk>
Date:	Wed, 27 Aug 2014 08:05:44 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Nicolin Chen <nicoleotsuka@...il.com>
Cc:	"Li.Xiubo@...escale.com" <Li.Xiubo@...escale.com>,
	Mark Rutland <mark.rutland@....com>,
	"timur@...i.org" <timur@...i.org>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"perex@...ex.cz" <perex@...ex.cz>, "tiwai@...e.de" <tiwai@...e.de>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of
 'big-endian-data'.

On Tue, Aug 26, 2014 at 11:53:56PM -0700, Nicolin Chen wrote:

> That's why I suggested previously: mention it in the commit comment.

> People will have no idea about what's the exact reason for this change.
> Any functional enhancement? Or a bug fix(more likely for this one).
> I'm not sure what I described in the previous mail is correct or not.
> But you probably should have added it into the commit comments.

Right, this is a good idea - make sure people can understand what the
goal of the change is.

> And Xiubo, this patch still hasn't fixed the issue of breaking the old DT,
> although system can pass during the probe() section.

Indeed.  Please do this.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)