linux-kernel - Re: [RESEND PATCH v3 1/6] charger: max14577: Add support for MAX77836 charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140827170416.GC24579@lee--X1>
Date:	Wed, 27 Aug 2014 18:04:16 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
	linux-pm@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Anton Vorontsov <anton@...msg.org>
Subject: Re: [RESEND PATCH v3 1/6] charger: max14577: Add support for
 MAX77836 charger

On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote:

> On śro, 2014-08-27 at 14:52 +0100, Lee Jones wrote:
> > On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote:
> > 
> > > Add support for MAX77836 charger to the max14577 driver. The MAX77836
> > > charger is almost the same as 14577 model except:
> > >  - No dead-battery detection;
> > >  - Support for special charger (like in MAX77693);
> > >  - Support for DX over-voltage protection (like in MAX77693);
> > >  - Lower values of charging current (two times lower current for
> > >    slow/fast charge, much lower EOC current);
> > >  - Slightly different values in ChgTyp field of STATUS2 register. On
> > >    MAX14577 0x6 is reserved and 0x7 dead battery. On the MAX77836 the
> > >    0x6 means special charger and 0x7 is reserved. Regardless of these
> > >    differences the driver maps them to one enum max14577_muic_charger_type.
> > > 
> > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> > > Cc: Kyungmin Park <kyungmin.park@...sung.com>
> > > Cc: Anton Vorontsov <anton@...msg.org>
> > > Cc: Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
> > > Cc: David Woodhouse <dwmw2@...radead.org>
> > > Acked-by: Lee Jones <lee.jones@...aro.org>
> > > ---
> > >  drivers/power/Kconfig                |  4 +-
> > >  drivers/power/max14577_charger.c     | 77 +++++++++++++++++++++++++++++-------
> > >  include/linux/mfd/max14577-private.h | 54 ++++++++++++++++++-------
> > 
> > Not quite so important here, but better to break these out too.  We
> > can arrange ourselves to that the set can go in together.  Just make
> > sure it's bisectable.
> 
> Are you sure? This will result in a patch which adds some
> code/symbols/defines used only by next (future) patch. Independent apply
> of such patch still won't make any sense because there won't be any user
> of this code.

That's fine.  I take in lots of patches which do nothing more than
adds/updates infrastructure.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/