linux-kernel - Re: [RESEND PATCH v3 3/6] charger: max14577: Configure battery-dependent settings from DTS and sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140827170503.GD24579@lee--X1>
Date:	Wed, 27 Aug 2014 18:05:03 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
	linux-pm@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Jenny Tc <jenny.tc@...el.com>
Subject: Re: [RESEND PATCH v3 3/6] charger: max14577: Configure
 battery-dependent settings from DTS and sysfs

On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote:

> On śro, 2014-08-27 at 14:50 +0100, Lee Jones wrote:
> > On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote:
> > 
> > > Remove hard-coded values for:
> > >  - Fast Charge current,
> > >  - End Of Charge current,
> > >  - Fast Charge timer,
> > >  - Overvoltage Protection Threshold,
> > >  - Battery Constant Voltage,
> > > and use DTS or sysfs to configure them. This allows using the max14577 charger
> > > driver with different batteries.
> > > 
> > > Now the charger driver requires valid configuration data from DTS. In
> > > case of wrong configuration data it fails during probe. Patch adds
> > > of_compatible to the charger mfd cell in MFD driver core.
> > > 
> > > The fast charge timer is configured through sysfs entry.
> > > 
> > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> > > Cc: Kyungmin Park <kyungmin.park@...sung.com>
> > > Cc: Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
> > > Cc: David Woodhouse <dwmw2@...radead.org>
> > > Cc: Jenny Tc <jenny.tc@...el.com>
> > > Cc: Mark Rutland <mark.rutland@....com>
> > > Acked-by: Lee Jones <lee.jones@...aro.org>
> > > ---
> > >  drivers/mfd/max14577.c               |   5 +-
> > 
> > Hmm... not sure why I Acked this.  The code looks okay, but can you
> > break out the MFD changed into a separate patch please?  You can add
> > my Ack to the broken out patch though.
> 
> Sure, I'll split it however the compatible here in mfd_cell makes sense
> only with this patch.

That's completely fine.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/