linux-kernel - Re: [PATCH 2/3] GPIO: gpio-dwapb: Support Debounce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1409297883.30155.29.camel@intel.com>
Date:	Fri, 29 Aug 2014 07:38:04 +0000
From:	"Shevchenko, Andriy" <andriy.shevchenko@...el.com>
To:	"atull@...nsource.altera.com" <atull@...nsource.altera.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"Chen, Alvin" <alvin.chen@...el.com>,
	"Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"Ong, Boon Leong" <boon.leong.ong@...el.com>,
	"gnurou@...il.com" <gnurou@...il.com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"Westerberg, Mika" <mika.westerberg@...el.com>,
	"dvhart@...ux.intel.com" <dvhart@...ux.intel.com>
Subject: Re: [PATCH 2/3] GPIO: gpio-dwapb: Support Debounce

On Thu, 2014-08-28 at 10:11 -0500, atull wrote:
> On Wed, 27 Aug 2014, Weike Chen wrote:

[]

> > +static inline u32 dwapb_read(struct dwapb_gpio *gpio, unsigned int offset)
> > +{
> > +	struct bgpio_chip *bgc	= &gpio->ports[0].bgc;
> > +	void __iomem *reg_base	= gpio->regs;
> > +
> > +	return bgc->read_reg(reg_base + offset);
> > +}
> > +
> > +static inline void dwapb_write(struct dwapb_gpio *gpio, unsigned int offset,
> > +			       u32 val)
> > +{
> > +	struct bgpio_chip *bgc	= &gpio->ports[0].bgc;
> > +	void __iomem *reg_base	= gpio->regs;
> > +
> > +	bgc->write_reg(reg_base + offset, val);
> > +}
> > +
> 
> Hello,
> 
> I don't understand the reason for adding dwapb_read and dwapb_write here.  
> The rest of the driver is using readl and writel.  I'd rather not see two 
> different methods being used in the same driver for register access.  
> Maybe I'm missing something, but if we need to add dwapb_read/write, then
> it should be used for all register access.

Alan, it was my proposal. I rather agree that is better to convert all
accesses to that.

-- 
Andy Shevchenko <andriy.shevchenko@...el.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.