linux-kernel - Re: [PATCH v3] iio: Add Dyna-Image AL3320A ambient light sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEnQRZAO1Zj5qX48A0ao_peiggE11WQJGYxcGmn6quZ-9O0P2w@mail.gmail.com>
Date:	Sat, 30 Aug 2014 13:45:30 +0300
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	Hartmut Knaack <knaack.h@....de>,
	Daniel Baluta <daniel.baluta@...el.com>,
	linux-iio@...r.kernel.org, Peter Meerwald <pmeerw@...erw.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Tsechih_Lin@...s.com
Subject: Re: [PATCH v3] iio: Add Dyna-Image AL3320A ambient light sensor driver

On Sat, Aug 30, 2014 at 1:00 PM, Jonathan Cameron <jic23@...nel.org> wrote:
> On 27/08/14 09:49, Hartmut Knaack wrote:
>> Daniel Baluta schrieb:
>>> Minimal implementation. This driver provides raw illuminance readings.
>>>
>>> This is based on drivers/hwmon/al3320.c (*) driver from msm tree written
>>> by Tsechih Lin <Tsechih_Lin@...s.com>
>>>
>>> * https://android.googlesource.com/kernel/msm.git
>>>
>>> Signed-off-by: Daniel Baluta <daniel.baluta@...el.com>
>> Hi, I think you should protect your write_raw with a mutex.
> Either that or drop the local store of the value and read it back from
> the device (assuming you can!).  That way everything becomes nice an
> atomic.  It's a rather narrow race, but Hartmut is correct in pointing it
> out.
>
> Few comments inline, mostly about my pet peeve: wrapper functions that don't
> do much.  Note I'm not that fussed if you really really want to keep them ;)
>
> Otherwise, looks good.
>

Thanks a lot for review Hartmut, Jonathan!

I will send v3 on Monday after I will re-test the changes.

Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/