linux-kernel - Re: [PATCH v2 2/3] iio: accel: BMC150: fix issues when CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5401AB4D.4000103@kernel.org>
Date:	Sat, 30 Aug 2014 11:45:33 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Laurentiu Palcu <laurentiu.palcu@...el.com>,
	linux-iio@...r.kernel.org
CC:	srinivas.pandruvada@...ux.intel.com, knaack.h@....de,
	lars@...afoo.de, pmeerw@...erw.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] iio: accel: BMC150: fix issues when CONFIG_PM_RUNTIME
 is not set

On 29/08/14 09:38, Laurentiu Palcu wrote:
> When CONFIG_PM_RUNTIME is not set, the following issues are seen:
>  * warning message at compilation time:
>     warning: 'bmc150_accel_get_startup_times' defined but not used [-Wunused-function]
>  * bmc150_accel_set_power_state() will always fail and reading the
>    accelerometer data is impossible;
Why? Would be good to have an explanation here...

If on is true then it will call pm_runtime_get_sync which calls __pm_runtime_resume
which when CONFIG_PM_RUNTIME is not defined returns 1 which is not an error.

In the on = false case it calls pm_runtime_put_autosuspend which calls __pm_runtime_suspend
which returns -ENOSYS and gives our error.

I'll add something to the patch description to this effect.
> 
> This commit fixes these.
> 
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@...el.com>
> ---
>  drivers/iio/accel/bmc150-accel.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/iio/accel/bmc150-accel.c b/drivers/iio/accel/bmc150-accel.c
> index ccb6cf8..0e6566a 100644
> --- a/drivers/iio/accel/bmc150-accel.c
> +++ b/drivers/iio/accel/bmc150-accel.c
> @@ -499,6 +499,7 @@ static int bmc150_accel_get_bw(struct bmc150_accel_data *data, int *val,
>  	return -EINVAL;
>  }
>  
> +#ifdef CONFIG_PM_RUNTIME
>  static int bmc150_accel_get_startup_times(struct bmc150_accel_data *data)
>  {
>  	int i;
> @@ -529,6 +530,12 @@ static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on)
>  
>  	return 0;
>  }
> +#else
> +static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on)
> +{
> +	return 0;
> +}
> +#endif
>  
>  static int bmc150_accel_set_scale(struct bmc150_accel_data *data, int val)
>  {
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/