lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 1 Sep 2014 09:55:43 +0200
From:	Geert Uytterhoeven <>
To:	Dirk Behme <>
Cc:	Mark Brown <>,
	Dmitry Eremin-Solenikov <>,
	"" <>,
	Liam Girdwood <>,
	Gokulkrishnan Nagarajan <>
Subject: Re: [PATCH] regulator: core: GPIO #0 is a valid GPIO

On Mon, Sep 1, 2014 at 9:46 AM, Dirk Behme <> wrote:
> On 29.08.2014 21:01, Mark Brown wrote:
>> On Fri, Aug 29, 2014 at 10:19:16PM +0400, Dmitry Eremin-Solenikov wrote:
>>> From: Dirk Behme <>
>>> With GPIO #0, this if statement will always fail. Remove this, the
>>> check for gpio_is_valid() is sufficent here.
>> No, read the archives
> Could you kindly give us a pointer to the relevant thread in the archive?
>> this will break boards using zero as default.
>> Any current boards should be using DT and so shouldn't be using fixed
>> GPIO numbers in the first place which will mean they'll not end up
>> getting zero as a valid GPIO.
> Hmm? What's wrong with a DT entry
> <&gpio1 0 0>;
> for ena_gpio resulting in zero as a valid GPIO?
>> If you are using zero as a GPIO for some
>> reason provide a way to specify that the GPIO is a real GPIO and not
>> just the default value for the struct.
> Do you want to say that GPIO #0 (<&gpio1 0 0>;) isn't a valid GPIO for
> config->ena_gpio?
> I wonder how this fits to
> "GPIOs are identified by unsigned integers in the range 0..MAX_INT"
> "If you want to initialize a structure with an invalid GPIO number, use
> some negative number (perhaps "-EINVAL");"
> then?

And include/asm-generic/gpio.h:

/* Platforms may implement their GPIO interface with library code,
 * at a small performance cost for non-inlined operations and some
 * extra memory (for code and for per-GPIO table entries).
 * While the GPIO programming interface defines valid GPIO numbers
 * to be in the range 0..MAX_INT, this library restricts them to the
 * smaller range 0..ARCH_NR_GPIOS-1.
 * ARCH_NR_GPIOS is somewhat arbitrary; it usually reflects the sum of
 * builtin/SoC GPIOs plus a number of GPIOs on expanders; the latter is
 * actually an estimate of a board-specific value.

#define ARCH_NR_GPIOS           256

 * "valid" GPIO numbers are nonnegative and may be passed to
 * setup routines like gpio_request().  only some valid numbers
 * can successfully be requested and used.
 * Invalid GPIO numbers are useful for indicating no-such-GPIO in
 * platform data and other tables.

static inline bool gpio_is_valid(int number)
        return number >= 0 && number < ARCH_NR_GPIOS;



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists